Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typeover still have issues in 4.4.x in Chrome/Safari in inline mode #3222

Open
bago opened this issue Sep 22, 2016 · 2 comments
Open

typeover still have issues in 4.4.x in Chrome/Safari in inline mode #3222

bago opened this issue Sep 22, 2016 · 2 comments

Comments

@bago
Copy link

bago commented Sep 22, 2016

Hi,

I use tinymce in inline mode to edit many kind of tags.

I see this issue happening in A tags, here is the reproducing fiddle:
http://fiddle.tinymce.com/17faab/3

I see 4.4.0 introduced some code to deal with the issue, but unfortunately I see 4.4.x works fine in Chrome in both Windows and Linux, but still show the issue (albeight with some differences) in both Chrome and Safari for MacOSX.

@ghost
Copy link

ghost commented Apr 26, 2018

@spocke Expanding on this issue:

git bisect identifies commit 4c9bfc5 as the source of this bug.

It appears that during the refactoring of "delete all" logic into BlockRangeDelete, some functionality for "typeover all" was lost. Specifically, the onkeypress code in Quirks.js lines 1070 through 1080 that were deleted in the above referenced commit are essential for WebKit and Gecko to properly handle the typeover all case.

This patch fixes the issue on the current master commit cf05d84.

@bago
Copy link
Author

bago commented May 18, 2020

I checked the fiddle and while tinymce 4.4.0 fixed it, sounds like 4.6.5 broke it again and it is broken in 5.2.2 too.

So sounds like a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant