Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The media plugin does not add facebook video when using the regular version #3613

Open
YovavGad opened this issue Apr 29, 2017 · 0 comments
Open

Comments

@YovavGad
Copy link

YovavGad commented Apr 29, 2017

When adding facebook videos it is showing a gray box with a video icon but the videos are not rendered,
This is what tinyMCE is adding by default (using the media plugin):

<p><video width="300" height="150" controls="controls">
<source src="https://www.facebook.com/AmericansAgainstNorthKorea/videos/1434819736539240/" /></video></p>

This is invalid and the video does not play

YouTube videos are rendered correctly using this (using the media plugin):
<p><iframe src="//www.youtube.com/embed/pfOAgKA7h7g" width="560" height="314" allowfullscreen="allowfullscreen"></iframe></p>

This is what is being added on the tinyMCE demo site (using the premium version I guess)
<div class="ephox-summary-card" style="max-width: 650px;" data-ephox-embed-iri="https://www.facebook.com/facebook/videos/10153231379946729"><a class="ephox-summary-card-link" href="https://www.facebook.com/facebook/videos/10153231379946729"> <span class="ephox-summary-card-title">How to Share With Just Friends</span> <span class="ephox-summary-card-description">How to share with just friends.</span> <span class="ephox-summary-card-author">Facebook</span> <span class="ephox-summary-card-website">Facebook</span> </a></div>

However, I think that a basic facebook video should be embedded like this in a div wrapper with a fb-video class (as shown on https://developers.facebook.com/docs/plugins/embedded-video-player):

<div class="fb-video" data-href="https://www.facebook.com/AmericansAgainstNorthKorea/videos/1434819736539240/" data-width="500" data-show-text="false">
	<div class="fb-xfbml-parse-ignore">
		<blockquote cite="https://www.facebook.com/AmericansAgainstNorthKorea/videos/1434819736539240/">
			<a href="https://www.facebook.com/AmericansAgainstNorthKorea/videos/1434819736539240/">How to Share With Just Friends</a>
			<p>How to share with just friends.</p>
			Posted by <a href="https://www.facebook.com/facebook/">Facebook</a> on Friday, December 5, 2014
		</blockquote>
	</div>
</div>

tinyMCE version 4.5.7 (2017-04-25)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants