Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background color being applied to a p tag that should not be. #3796

Closed
SimplyCorey opened this issue Jul 7, 2017 · 7 comments
Closed

Background color being applied to a p tag that should not be. #3796

SimplyCorey opened this issue Jul 7, 2017 · 7 comments

Comments

@SimplyCorey
Copy link

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

The background color is being applied to a p tag that should not have it applied.

1: Visit http://fiddle.tinymce.com/EUfaab/1
2. Triple click on the area that says triple click to highlight the p tag
3. Change the background color.
4. Notice that the bottom p tag changes it's background color as well.

What is the expected behavior?

The bottom p tag should not change the background color.

@SimplyCorey
Copy link
Author

This seems to only occur when the p tag under the highlighted area has a font-size attribute.

@Silviu-Marian
Copy link

This occurs with with tables too

http://fiddle.tinymce.com/fVfaab/1

Select the first paragraph, change the background color. This happens:

image

@SimplyCorey
Copy link
Author

This appears to only affect Chrome.

@Silviu-Marian
Copy link

@SimplyCorey actually it's reproducible in other browsers too.

I think it's a deeper issue and Chrome has the triple-click selection showing #3810. In Firefox you can select the first letter of the paragraph, hold down Shift, press the End key, then with Shift still selected press Arrow Right. It will (invisibly) select the paragraph ending. After that, changing the background color will also extend to other parts.

@SimplyCorey
Copy link
Author

SimplyCorey commented Sep 19, 2017

@spocke Anything you need from me to confirm this bug? I'll gladly fix it as well if you want to point me into the right direction.

@SimplyCorey
Copy link
Author

Looks like this is fixed in 4.6.6

@SimplyCorey
Copy link
Author

Fixed bug where background color wasn't applied correctly on some partially selected contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants