Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon not found #5687

Closed
June0611 opened this issue May 21, 2020 · 7 comments
Closed

icon not found #5687

June0611 opened this issue May 21, 2020 · 7 comments

Comments

@June0611
Copy link

What is the current behavior? Describe the bug

image

Please provide the steps to reproduce and if possible a minimal demo of the problem via fiddle.tinymce.com or similar.

Nothing changes, just repackage, and then this happens

What is the expected behavior?

Which versions of TinyMCE, and which browser / OS are affected by this issue? Did this work in previous versions of TinyMCE?

5.2.1

@lnewson
Copy link
Contributor

lnewson commented May 21, 2020

@June0611 can you please include a way to replicate the issue? In TinyMCE 5.2.1 the icons are embedded in core, so it'd be quite surprising to see that issue without manually removing them from the registry.

If you're using TinyMCE 5.3.0, which was only released a couple hours ago, then it now has the icons in a separate file icons/default/icons.js or icons/default/icons.min.js you'll need to make sure you copy across when deploying TinyMCE.

@June0611
Copy link
Author

@June0611 can you please include a way to replicate the issue? In TinyMCE 5.2.1 the icons are embedded in core, so it'd be quite surprising to see that issue without manually removing them from the registry.

If you're using TinyMCE 5.3.0, which was only released a couple hours ago, then it now has the icons in a separate file icons/default/icons.js or icons/default/icons.min.js you'll need to make sure you copy across when deploying TinyMCE.

Sorry, the current quoted version is 5.3.0, which has been resolved, thank you very much

@lugosium
Copy link

Hello @lnewson,

Is there a way or option to activate to get the old behaviour, not load the icons via another request?

Thanks

@lnewson
Copy link
Contributor

lnewson commented May 25, 2020

@lugosium it's a build time thing, so there's no setting. However, you can just manually bundle the icons JS with the TinyMCE JS. eg:

cat tinymce.min.js icons/default/icons.min.js > tinymce.full.min.js

If you're using a module loader, just be sure to include something like this:

import 'tinymce/icons/default`;

Note: The above will be added to our module loader docs when 5.3 is released to enterprise.

@lugosium
Copy link

Working like a charm! Thank you very much.

@pavel-mailpoet
Copy link

@lnewson when using the version with module loader import 'tinymce/icons/default;I get an error:Uncaught ReferenceError: tinymce is not defined` How to fix that?

@arnaudbey
Copy link

@pavel-mailpoet using require('tinymce/icons/default') dit the job for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants