Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis config #3

Closed
mre opened this issue Oct 27, 2018 · 4 comments
Closed

Add Travis config #3

mre opened this issue Oct 27, 2018 · 4 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@mre
Copy link
Member

mre commented Oct 27, 2018

Would be great to build the project on every new commit / pull request.
For that, we could add a Travis configuration.

@mre mre added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 27, 2018
@schalkneethling
Copy link
Contributor

@mre Hey there, I would like to take this one. I am guessing that you want to run the default Rust build script on PR/commit i.e. cargo build

Is there a specific version of Rust you want to target? Perhaps simply release?
Do you also want to run cargo test?

@mre
Copy link
Member Author

mre commented Oct 27, 2018

Hey @schalkneethling,
yeah I think a setup like this would be a good start: https://github.com/mre/mos6502/pull/4/files
This runs cargo build and cargo test. You might also want to add a badge to the README.md if you can. Once we got this up and running, we might wanna think about adding support for wasm-pack to Travis, as described in #2.

@schalkneethling
Copy link
Contributor

Sounds good @mre - on it.

@mre
Copy link
Member Author

mre commented Oct 28, 2018

Fixed by @schalkneethling in #6. 🎉

@mre mre closed this as completed Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants