Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest Electron stable #68

Closed
erickzhao opened this issue Jun 5, 2023 · 0 comments · Fixed by #106
Closed

Upgrade to latest Electron stable #68

erickzhao opened this issue Jun 5, 2023 · 0 comments · Fixed by #106
Labels
dependencies Pull requests that update a dependency file has-description size:m

Comments

@erickzhao
Copy link
Member

erickzhao commented Jun 5, 2023 •
edited

Problem statement

Sleuth is running on Electron v13.3.0. In order to stay up to date with security best practices, we should be staying up to date with Electron as much as possible.

Steps

We should upgrade the Electron version one major version at a time and validate that the build and tests pass each time.

https://www.electronjs.org/docs/latest/breaking-changes
@erickzhao erickzhao added the dependencies Pull requests that update a dependency file label Jun 5, 2023
@JohanDelao JohanDelao mentioned this issue Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file has-description size:m
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: Upgrade to latest Electron stable tinyspeck/sleuth
1 participant
@erickzhao