-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RadioLib license #2
Comments
Hey Jan, this was by accident. I am new to github. And I missed the reaction window so they closed the repo. I wanted to say thank you. Your work is really great and helped me a lot to understand the SX126X datasheet , the chip init sequence and saved days of time! As you requested, I created a file which includes your license: Hope this is ok! |
Thank you, this is perfectly fine. As I've said previously, I encourage others to adapt my code, but even on the Internet, there are still rules to follow ;). The usual way to modify code written by others on GitHub is to create a fork - the advantage is that it keeps the history of all files (same way Git does) and issues with licensing can be clarified easily. I'll withdraw the DMCA claim once GitHub sends it back to me. PS: You might want to update the contact email in library.json, the one that's in there doesn't seem to be working. |
Hello,
First of all, I want to say that your home automation LoRa gateways (as well as all the other home autmation devices) look really cool!
That being said, in your SX126X library, you have obviously used large portions of RadioLib code, which is developed by me. I don't intend to discourage people from doing that - quite the contrary, adapting code written by other people is one of the core ideas of open source development.
However, RadioLib MIT License explicitly states that:
This is usually understood as including the original copyright holder's name in the appropriate section of the software. Would it be possible to add this copyright notice, as to comply with RadioLib license?
Thank you very much.
The text was updated successfully, but these errors were encountered: