-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add header configuration helper to simplify header setting #1293
Conversation
This introduces a `Headers` class with a few pre-defined header names to have a DSL to easily configure headers. This has been created with the OWASP security headers in mind, but can be used for anything. Closes javalin#1246
sorry for any kotlins embarassments :-) happy to reiterate on this |
Great work @spinscale, I left a few comments. |
one more thing to discuss might be to make this as an |
I think |
renamed to |
Looks good from my end! Do you want to make more changes, or are you ready to merge? |
ready to merge! |
Perfect, thank you very much! |
This introduces a
Headers
class with a few pre-defined header names tohave a DSL to easily configure headers. This has been created with the
OWASP security headers in mind, but can be used for anything.
Closes #1246