Skip to content
This repository has been archived by the owner on Jun 22, 2020. It is now read-only.

goog_drv - 1000 changes per request #2

Merged
merged 1 commit into from Jun 16, 2014

Conversation

Lewis-Clayton
Copy link
Contributor

Hi tiredpixel,

It turns out that the api only returns the latest 100 items. So to the 101st file won't be seen be Ryespy. Fortunately the Google Drive Gem allows params to be passed into the files request. Looking at the docs (https://developers.google.com/google-apps/documents-list/#retrieving_fewer_changes_per_request) a maximum of 1000 items can be passed back by using this param: &max-results=1000.

While this is ultimately a limitation people should be aware of this PR mitigates it for most use cases.

Regards,

Lewis

@tiredpixel tiredpixel merged commit 81c4c39 into tiredpixel:master Jun 16, 2014
@tiredpixel tiredpixel added the bug label Jun 16, 2014
@tiredpixel
Copy link
Owner

Dear Lewis,

Thank you for this contribution; I'm afraid I missed that entirely. I've been thinking about how best to proceed with this issue; ideally, I think there should be no maximum at all. I had a quick look and it seems that might not be trivial, however, possibly requiring changes upstream. But I think that your patch of changing the limit to the maximum of 1000 is much better than the default of 100, so I've decided to merge and create new issue #3 which I or somebody can hopefully get to at some point to investigate the matter yet further beyond the link you kindly provided, and hopefully end up with a solution without a limit. In the meanwhile, I intend to make a note of this outstanding issue and create a patch release. Thank you again! :)

Peace,
tiredpixel

@tiredpixel
Copy link
Owner

@Lewis-Clayton, released in Ryespy 1.1.1 . Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants