Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Bug Report: Empty Copy Beep not work #315

Closed
4 of 5 tasks
felixadlen opened this issue Jan 7, 2024 · 5 comments
Closed
4 of 5 tasks

🐞 Bug Report: Empty Copy Beep not work #315

felixadlen opened this issue Jan 7, 2024 · 5 comments
Assignees
Labels
bug Something isn't working fixed in next release The issue will be closed once next release is available

Comments

@felixadlen
Copy link

Please confirm the following:

  • I have carefully read the README
  • I have searched through the issues page but couldn't find a solution.(Including issue that has been closed)
  • Easydict has been upgraded to the latest version
  • I understand and agree to the above, and understand that the project maintainer has limited energy, issues that do not follow the rules may be ignored or closed directly

Problem description

Triggering "Select Text Translate" command with a keyboard shortcut adds a Empty Copy Beep, if no text is selected.
If text is selected, no beep.

Latest version (2.5.0) and I've tried toggle the "Disable Empty Copy Beep" but the beep is always there if no text is selected.

I

Reproduction steps

Triggering "Select Text Translate" command with a keyboard shortcut adds a Empty Copy Beep, if no text is selected.
If text is selected, no beep.

Latest version (2.5.0) and I've tried toggle the "Disable Empty Copy Beep" but the beep is always there if no text is selected.

Screenshot

image

Expected result

No audio beep when triggering the shortcut when no text is selected

Proposed solution (optional)

No response

Device type and OS version

Apple M2, macOs 14.1.2

Are you willing to submit a PR to fix this issue?

  • I'm willing to submit a PR
@felixadlen felixadlen added the bug Something isn't working label Jan 7, 2024
Copy link

github-actions bot commented Jan 7, 2024

Hello felixadlen, Thank you for your first issue contribution 🎉

@tisfeng tisfeng changed the title 🐞 Bug Report: 🐞 Bug Report: Empty Copy Beep not work Jan 7, 2024
@tisfeng
Copy link
Owner

tisfeng commented Jan 7, 2024

Thank you for your feedback, we didn't change the code related to disabling beeps in recent versions, and this issue will most likely always exist.

In the beginning, due to the complexity of this issue #111 , there is no good solution at the moment, that's why we provide a 'Disable Empty Copy Beep' option, but this option may cause playing music to lag #83 , so currently it's only really enabled if no sound is playing.

To make matters worse, the current method for determining whether a computer has the Play Sound feature is a private method that is unreliable and sometimes fails, in which case 'Disable Empty Copy Beep' will not work.

@tisfeng
Copy link
Owner

tisfeng commented Jan 7, 2024

It's only sometimes that this problem occurs, at which point you can try playing-pausing the music to see if you can temporarily fix the problem.

@tisfeng tisfeng self-assigned this May 4, 2024
@tisfeng tisfeng added fixed in next release The issue will be closed once next release is available and removed PR wanted labels May 4, 2024
@tisfeng
Copy link
Owner

tisfeng commented May 4, 2024

I've found a solution https://x.com/tisfeng/status/1786629578557186391 , I'll try to fix this issue later.

@tisfeng
Copy link
Owner

tisfeng commented May 12, 2024

This bug has been fixed in version 2.7.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next release The issue will be closed once next release is available
Projects
None yet
Development

No branches or pull requests

2 participants