Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In version 3.0 Beta - Edge between 2 nodes goes away if the nodes are close to each other #41

Closed
DraksBG opened this issue Nov 3, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@DraksBG
Copy link

DraksBG commented Nov 3, 2022

Me and @antipasvasil are collogues and are working on the Beta version. There is a problem when 2 nodes are close to each other - the edge between them goes to a fixed location(at (0, 0) coordinates.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any nodes that have connection (Edge) between them
  2. Start dragging one of the node towards the other node that is connected
  3. As they get closer the connection (Edge) has been transferred to 0,0 coordinates

Expected behavior
No matter how close any nodes that are connected are getting close the connection should remain between them and not disappear

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):
OS: Windows 10, 11
Browser Chrome, Firefox
screen_1
Screen_2

@DraksBG DraksBG added the bug Something isn't working label Nov 3, 2022
@antipasvasil
Copy link

antipasvasil commented Nov 3, 2022

@tisoap i would like once again to thank you of the quick response regarding updaiting vesrion. Exactly as @DraksBG explained, there is a problem when 2 nodes are close to each other. We know how to mask it but it is not good aproache. I will really appreciate if you can help us to handle it. Thank you in advance.

@tisoap
Copy link
Owner

tisoap commented Nov 3, 2022

Hey @DraksBG ! Could you please provide a minimal working example on CodeSandbox? I won't tackle issues where the problem can't be reproduced

@tisoap
Copy link
Owner

tisoap commented Nov 3, 2022

@antipasvasil No problem! I'll warn you in advance: I won't be able to tackle issues in a timely manner, as I'm the sole maintainer with a full time job working on web development. To develop even more after work hours or on weekends is very low on my list of priorities

If you guys have a very pressing issue, I recommend forking this library and implement the fixes on your own, or not using smart edges at all (the default edges on React Flow 11 are a bit smarter by default, so you might not even have a need for this package anymore)

@DraksBG DraksBG closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants