Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for squared off edges #8

Closed
usamathpc opened this issue Dec 21, 2021 · 3 comments
Closed

Add option for squared off edges #8

usamathpc opened this issue Dec 21, 2021 · 3 comments
Labels
enhancement New feature or request
Projects

Comments

@usamathpc
Copy link

Nice work!

I was wondering if there was a way to make the edges squared off instead of the non-uniform curves that it currently draws.

@usamathpc
Copy link
Author

usamathpc commented Dec 21, 2021

It's being implemented in the following block in generatePath.ts I guess?

 const finder = new AStarFinder({
    diagonalMovement: DiagonalMovement.Always,
    allowDiagonal: true,
    dontCrossCorners: true,
  });

@tisoap
Copy link
Owner

tisoap commented Dec 25, 2021

Hey @usama-pc ! The non-uniform curves are actually implemented by drawSmoothLinePath on src/SmartEdge/drawSvgPath.ts. I do have a drawStraightLinePath implementation but I haven't exposed it yet

@tisoap tisoap mentioned this issue Dec 25, 2021
@tisoap
Copy link
Owner

tisoap commented Dec 25, 2021

@usama-pc Version 0.4.0 now exposes more options which allows more control over the line shape.

@tisoap tisoap closed this as completed Dec 25, 2021
@tisoap tisoap added the enhancement New feature or request label Dec 25, 2021
Repository owner locked as resolved and limited conversation to collaborators Apr 16, 2022
@tisoap tisoap changed the title squared off edges Add option for squared off edges Apr 27, 2022
@tisoap tisoap added this to Done in Kanban Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Kanban
  
Done
Development

No branches or pull requests

2 participants