Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace npm run dev to npm run start #35

Closed
titouancreach opened this issue Oct 5, 2018 · 4 comments
Closed

replace npm run dev to npm run start #35

titouancreach opened this issue Oct 5, 2018 · 4 comments
Labels
feature-request hacktoberfest Get your shirt!

Comments

@titouancreach
Copy link
Owner

titouancreach commented Oct 5, 2018 •
edited

create react app and many other project use npm start to start the dev server, maybe we can change the name script in the example to match this
@keeganthomp
Copy link

I'll work on this 👍

@titouancreach
Copy link
Owner Author

Super! @keeganthomp

@MarceloAlves MarceloAlves mentioned this issue Oct 5, 2018
Merged
@keeganthomp
Copy link

JK. Looks like Marcelo got it :)

@titouancreach
Copy link
Owner Author

titouancreach commented Oct 5, 2018 •
edited

Yes he was faster :) there is still some issues in the list :D
You can also create issue if you see something wrong on the code/doc/ci/whatever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request hacktoberfest Get your shirt!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@titouancreach @keeganthomp