Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keras-contrib pull request #8

Closed
ahundt opened this issue Feb 18, 2017 · 6 comments
Closed

keras-contrib pull request #8

ahundt opened this issue Feb 18, 2017 · 6 comments

Comments

@ahundt
Copy link

ahundt commented Feb 18, 2017

Once #7 is committed and verified to work with theano, I'm hoping to look at extending your keras-contrib densenet.py submission to support densenet-fcn as well.

Would that be okay with you?

I'll plan to also include a conversion script for pascal_voc.

@titu1994
Copy link
Owner

I actually feel that the core DenseNet for classification and DenseNet for semantic segmentation should be separate.

The idea is different, one is for classification and another is for semantic segmentation. While they use DenseNets, semantic segmentation has a very different form to ordinary DenseNets.

That is why I have separated this repository from the pure densenet model builder repo, because the ideas behind them are different. It does not make sense to shoehorn semantic segmentation model creation code into DenseNet creation code.

@ahundt
Copy link
Author

ahundt commented Feb 18, 2017

The purposes are definitely different, but the differences are still kind of small though.

If I read things correctly the only differences are:

  • rename transition_block transition_down_block
  • add transition_up_block (plus optional alternative upsampling layers)
  • add create_dense_net_fcn()
  • add flag for fcn options to DenseNet class

@ahundt
Copy link
Author

ahundt commented Feb 18, 2017

I mean it can also be in a separate DenseNetFCN class that imports DenseNet. That's easy enough, though I think a single class may be more sensible.

@titu1994
Copy link
Owner

Yes a class DenseNetsFCN which imports DenseNet sounds better.

It may be my bias, but I tend to keep projects with different end goals completely separate, so as to avoid overcomplicating either project.

Importing core methods from DenseNet and adding the necessary additional methods to build the DenseNetFC sound like a good idea.

Would you do it or should I? Since it's your idea I feel like you should add the PR to Keras contrib but I'm OK with anything.

@ahundt
Copy link
Author

ahundt commented Feb 18, 2017

sure I can do it, it will be a while because I need to implement a converter from raw pascal_voc to a keras model setup so I can submit a dataset alongside the semantic segmentation code to train from.

some conversion stuff:
https://github.com/ahundt/tf-image-segmentation/blob/ahundt-keras/tf_image_segmentation/recipes/pascal_voc/convert_pascal_voc_to_tfrecords.ipynb
https://github.com/martinkersner/train-DeepLab

request for license permission:
martinkersner/train-DeepLab#23

@titu1994
Copy link
Owner

Cool I'll leave it to you then.

I'm quite a bit tied up in assignments and midterms so I won't be as active for the next week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants