Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Update typo in wiki for VCR configuration #66

Closed
martinbjeldbak opened this issue Apr 11, 2019 · 3 comments
Closed

Documentation: Update typo in wiki for VCR configuration #66

martinbjeldbak opened this issue Apr 11, 2019 · 3 comments

Comments

@martinbjeldbak
Copy link

I am unable to update the wiki so please find description of change request in this issue.

Issue: The ignore_hosts call for VCR configuration is a method that takes an array and not an assignment.

The error is on this wiki section: https://github.com/titusfortner/webdrivers/wiki/Using-with-VCR-or-WebMock#vcr

It should be

VCR.configure do |config|
  config.ignore_hosts([
    "chromedriver.storage.googleapis.com",
    "github.com/mozilla/geckodriver/releases",
    "selenium-release.storage.googleapis.com",
    "developer.microsoft.com/en-us/microsoft-edge/tools/webdriver"
  ])
end

See here for example usage: https://github.com/vcr/vcr/blob/806dcebfd87123b45cb57c2152be568030864c4b/spec/support/shared_example_groups/hook_into_http_library.rb#L553

@kapoorlakshya
Copy link
Collaborator

Thanks, @martinbjeldbak! I have updated the wiki.

@martinbjeldbak
Copy link
Author

@kapoorlakshya apologies, I've done some more playing around and it turns out it has to be a list of arguments, not an array

VCR.configure do |config|
  config.ignore_hosts(
    "chromedriver.storage.googleapis.com",
    "github.com/mozilla/geckodriver/releases",
    "selenium-release.storage.googleapis.com",
    "developer.microsoft.com/en-us/microsoft-edge/tools/webdriver"
  )
end

@kapoorlakshya
Copy link
Collaborator

No problem! Updated it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants