Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Security bug) PasswordResetConfirm doesn't check token! It allows to change password for anyone #47

Closed
axens opened this issue Jan 27, 2015 · 3 comments
Labels

Comments

@axens
Copy link

axens commented Jan 27, 2015

https://github.com/Tivix/django-rest-auth/blob/master/rest_auth/serializers.py#L116

Perhaps, you forgot to raise an exception, for example like that:

if self._errors:
            raise serializers.ValidationError(self._errors)
@mateusz-sikora
Copy link
Contributor

I think that is_valid() method of Serializer class will raise an exception if there are any items in self._errors list. I'm almost sure that it was working like that in DRFv2.4, but will check it for DRFv3.0.

Thanks for reporting this!

@mateusz-sikora
Copy link
Contributor

@axens You were right! Patch is already pushed to the repo, will release new version shortly.
Thanks once again for catching this bug!

@axens
Copy link
Author

axens commented Jan 27, 2015

@mateusz-sikora Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants