Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance when sensors are relatively fast #12

Closed
henry0572 opened this issue Jul 9, 2020 · 3 comments
Closed

Performance when sensors are relatively fast #12

henry0572 opened this issue Jul 9, 2020 · 3 comments

Comments

@henry0572
Copy link

Hello!
Thank you for a great job.

I was looking at the LIO-SAM code, and the following commented out section caught my attention.

https://github.com/TixiaoShan/LIO-SAM/blob/master/src/imageProjection.cpp#L450-L459

        // If the sensor moves relatively slow, like walking speed, positional deskew seems to have little benefits. Thus code below is commented.

        // if (cloudInfo.odomAvailable == false || odomDeskewFlag == false)
        //     return;

        // float ratio = relTime / (timeScanNext - timeScanCur);

        // *posXCur = ratio * odomIncreX;
        // *posYCur = ratio * odomIncreY;
        // *posZCur = ratio * odomIncreZ;

What were the results when sensors are relatively fast and you uncommented above?
Also, is there a dataset that I can try?

@TixiaoShan
Copy link
Owner

TixiaoShan commented Jul 9, 2020

I don't have a dataset that has a very fast speed. The maximum speed for my dataset is 6km/h. So the difference if pretty small when it is commented. I imagine those lines will be very useful for datasets gathered by a car.

@henry0572
Copy link
Author

I see.
Thanks for the reply.

@ellieko
Copy link

ellieko commented Dec 3, 2023

@TixiaoShan Hello, thanks for sharing this package! I'm trying out this package for a car that is moving with a fast speed (around 40-50mph) but it doesn't... work well. Do you have any advice on parameter setting? I changed some params in params.yaml, including extrinsicRot, and commented out the condition, if (vel.norm() > 30)..., in imuPreintegration.cpp, but its point cloud map gets disconnected after a few seconds of the bag. Any advice would be really appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants