Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<html> attributes #46

Open
CanRau opened this issue Aug 5, 2018 · 2 comments
Open

<html> attributes #46

CanRau opened this issue Aug 5, 2018 · 2 comments
Labels
enhancement help wanted

Comments

@CanRau
Copy link

CanRau commented Aug 5, 2018 •
edited

While trying to migrate to react-head I noticed react-helmets and I'm not sure if current react-head can do this already?
If yes I would like some help, if not might this be integrated some day or should I handle it differently?

By the way, the lang attribute is still relevant as far as I can tell right?

edit: should have mentioned that I have actually multiple languages, so it's not about a static declaration but about a dynamic one based on props

maybe I just update it using plain js?
@tizmagik
Copy link
Owner

tizmagik commented Aug 7, 2018

If I understand your question correctly, right now react-head is meant to be used to add/update/remove HTML tags within the <head /> tag, and not for updating the <html /> tag itself. I think using plain JS to update the attributes on <html /> make the most sense for now.

I would be open to reviewing a PR that adds support for updating attributes for body, html and title tags for feature parity with react-helmet.

@CanRau
Copy link
Author

CanRau commented Aug 9, 2018

okay, I'll look into it once I've got time and maybe come back with a PR, can't promise anything yet ;-)

could be closed, or kept open maybe someone else feels the need to add a PR :D

@bruno-vaz bruno-vaz mentioned this issue Jul 27, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tizmagik @CanRau