Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a new input to optionally set names as markdown anchors #480

Merged
merged 26 commits into from
Jun 7, 2023

Conversation

ViacheslavKudinov
Copy link
Contributor

@ViacheslavKudinov ViacheslavKudinov commented Jun 3, 2023

  • added new Action input markdown_links to set input, output, and secret names as markdown anchors
  • fixes workflow permissions to push change down by tests back to the "feature" branch
  • updated tests to cover new input

@ViacheslavKudinov ViacheslavKudinov changed the title [Feat] Added input to optionally set names as markdown anchors feat: Added input to optionally set names as markdown anchors Jun 3, 2023
@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Patch coverage: 76.47% and no project coverage change.

Comparison is base (1b233f2) 85.34% compared to head (ddb0012) 85.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #480   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files           1        1           
  Lines         116      116           
=======================================
  Hits           99       99           
  Misses         12       12           
  Partials        5        5           
Impacted Files Coverage Δ
cmd/root.go 85.34% <76.47%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ViacheslavKudinov ViacheslavKudinov changed the title feat: Added input to optionally set names as markdown anchors feat: Add a new input to optionally set names as markdown anchors Jun 3, 2023
@ViacheslavKudinov ViacheslavKudinov marked this pull request as ready for review June 3, 2023 16:30
internal/utils/markdown_link.go Fixed Show fixed Hide fixed
internal/utils/markdown_link.go Fixed Show fixed Hide fixed
internal/utils/markdown_link.go Fixed Show fixed Hide fixed
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdownlint (reported by Codacy) found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

internal/types/reusable.go Fixed Show fixed Hide fixed
internal/types/reusable.go Fixed Show fixed Hide fixed
internal/types/reusable.go Fixed Show fixed Hide fixed
internal/types/action.go Fixed Show fixed Hide fixed
internal/types/action.go Fixed Show fixed Hide fixed
@ViacheslavKudinov
Copy link
Contributor Author

ViacheslavKudinov commented Jun 6, 2023

Merged with main and adopted with the mind of deprecated.
@jackton1 could you, please, take a look when you have time?

@jackton1
Copy link
Member

jackton1 commented Jun 7, 2023

@ViacheslavKudinov Sure, I'm reviewing it now.

internal/types/action.go Outdated Show resolved Hide resolved
@jackton1 jackton1 merged commit b750d7a into tj-actions:main Jun 7, 2023
25 of 26 checks passed
@ViacheslavKudinov
Copy link
Contributor Author

Thanks for adjustments to the feature @jackton1 !

@jackton1
Copy link
Member

jackton1 commented Jun 7, 2023

Anytime and Thanks again for the excellent PR and clear documentation. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants