Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dedupe the output list of changed files #151

Closed
2 tasks done
jackton1 opened this issue Aug 2, 2021 · 2 comments · Fixed by #153
Closed
2 tasks done

[BUG] Dedupe the output list of changed files #151

jackton1 opened this issue Aug 2, 2021 · 2 comments · Fixed by #153
Labels
bug Something isn't working

Comments

@jackton1
Copy link
Member

jackton1 commented Aug 2, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug?

There's a possibility of returning the same file twice when it matches one or more regex used in the files input.

To Reproduce

  1. Create a .github/workflows/test.yml
  2. Enter the following
  uses: tj-actions/changed-files@v9
  with:
    files: |
		path-to-files
	    .(js|ts|tsx|scss)$
  ...

What OS are you seeing the problem on?

all

Expected behavior?

The list of changed files returned shouldn't be duplicated.

Relevant log output

All changed files: path-to-files/test.js path-to-files/test.js

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jackton1 jackton1 added the bug Something isn't working label Aug 2, 2021
@jackton1 jackton1 linked a pull request Aug 6, 2021 that will close this issue
@mabdullah99
Copy link

@jackton1 I still get duplicate outputs in all_changed_and_modified_files when using both files and dir_names inputs

@jackton1
Copy link
Member Author

@mabdullah99 can you provide the related logs where you saw duplicates ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants