Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add option to ignore submodules #2045

Closed
2 tasks done
rantoniuk opened this issue Apr 15, 2024 · 1 comment · Fixed by #2047
Closed
2 tasks done

[Feature] add option to ignore submodules #2045

rantoniuk opened this issue Apr 15, 2024 · 1 comment · Fixed by #2047
Labels
enhancement New feature or request

Comments

@rantoniuk
Copy link

Is this feature missing in the latest version?

  • I'm using the latest release

Is your feature request related to a problem? Please describe.

It's great that the submodules are supported, but I would actually like to ignore submodules during the scans. This is because the changes for submodules should be normally managed in their own workflows, not in the target repository that is consuming them.

Currently I see in the logs:

Set 'fetch_additional_submodule_history: true' to fetch additional submodule history for: subm

Describe the solution you'd like?

I'd like to disable changed files detection in the paths defined by .gitmodules, e.g. ignore_submodules: true/false.

Describe alternatives you've considered?

I'm ignoring the submodule directory now via

files_ignore: |
  subA
  subB

but that doesn't improve the performance and it still shows the warning above. Also I need to maintain that list separately while it could be auto-populated from .gitmodules or from git submodule | awk '{print $2;}'.

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@rantoniuk rantoniuk added the enhancement New feature or request label Apr 15, 2024
@jackton1
Copy link
Member

jackton1 commented Apr 17, 2024

Hi @rantoniuk you can now disable submodule diffs by setting the exclude_submodules to true using the latest https://github.com/tj-actions/changed-files/releases/tag/v44.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants