Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Project versions are mutated without warning #382

Closed
3 tasks done
MattCWheeler opened this issue Feb 16, 2022 · 2 comments
Closed
3 tasks done

[BUG] Project versions are mutated without warning #382

MattCWheeler opened this issue Feb 16, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@MattCWheeler
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Does this issue exist in the latest version?

  • I'm using the latest release

Describe the bug?

I noticed this because I had pinned to 'tj-actions/changed-files@v13.1' and things had been working well for weeks, and suddenly (as of this morning) changed files are being incorrectly filtered out by a files glob.

This led me to suspect that v13.1 wasn't the same code as it was previously. I then notices that in https://github.com/tj-actions/glob/tags (a dependency of this project) nearly all of the version tags actually point to the same commit.

Did some release go very wrong?

Notably things work again with the latest version v15 (also, how is this project versioned? I would have expected v15.0.0 or similar).

To Reproduce

Go to https://github.com/tj-actions/glob/tags.

What OS are you seeing the problem on?

all

Expected behavior?

Git tags are immutable.

Relevant log output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@MattCWheeler MattCWheeler added the bug Something isn't working label Feb 16, 2022
@github-actions
Copy link
Contributor

Thanks for reporting this issue, don't forget to star this project to help us reach a wider audience.

@jackton1
Copy link
Member

jackton1 commented Feb 17, 2022

@MattCWheeler This was an oversight on my part a change to the glob action was wrongly pushed and clobbered the existing tags.

The error introduced in previous v13.x versions was due to a missing input which has been fixed.

We currently maintain two versioning schemes (major).(patch) version tags and semantic versions mentioned here

The semver was introduced by error when we transitioned from v9.x -> v10.

We've had to maintain v1.0.0 -> v5.0.0 which essentially points to v10 -> v15 respectively. This was done to prevent things like dependabot or renovate bots from detecting new releases.

The long term goal would be to transition fully to semantic versioning and major version tags but the current usage in the wild makes this challenging.

There's currently no recommended approach to warn users without having to update legacy versions. I'll be adding a sentence or two to the docs on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants