[BUG] all_old_new_renamed_files is empty when providing a glob pattern. #467
Labels
bug
Something isn't working
Comments
|
Thanks for reporting this issue, don't forget to star this project to help us reach a wider audience. |
|
Was this completed? I dont see any comments that it was picked up or added to a version. |
|
@Steve-Groner @hestonhoffman @mansurhamidov14 This is now available in the latest release v19.3 |
|
It isnt working for me. I see the new line, but it is empty. Resolving repository path... |
|
Last line I thought should contain the list of old and new names.. Here is my github action call ` - name: Get Renamed robots.txt files Then consumed using:
|
|
@jackton1 See above, this doesnt appear to be working as expected. |
|
@Steve-Groner Can you post the entire workflow configuration you have setup and the full log output. |
|
@jackton1 Here is the action |
|
@jackton1 Here are the logs... |
|
@stevegroner Can you test it using this branch Using - name: Get Renamed robots.txt files
id: renamed-files-robots-files
uses: tj-actions/changed-files@chore/test-rename
with:
files: ./robots_files/*
old_new_files_separator: "|"
|
Merged
|
Same response. |
|
FYI, same with or without the token line... |
|
@stevegroner Can you verify that the commit being compared has the renamed files from all the tests I ran it returns an output with the old and new filenames? I recommend using the pull_request event to verify that the rename is present on a pull request branch. on:
pull_request:
branches:
- mainTestOn Workflow Dispatch See:
On Pull request On Push |
|
I tested it with the following: The result was the same. I did not see any difference. |
|
@jackton1 If I add this step to the bottom you can see the files do appear using git commands |
|
@stevegroner Can you verify that the result is the same without selecting Deleted files |
|
@jackton1 When I run locally here is what I get |
|
@stevegroner From the code, we run I've released a new version v20.1 but I suggest running the above to see if the output is the same |
|
Yep that works locally let me try to push to the repo and see. |
|
Interesting... here is the action The Command works but still returns nothing from the changed-files action itself. |
|
Could this be some sort of GIT version mismatch or something.... |
|
@stevegroner After reviewing your comment again this clearly doesn't seem to be a version mismatch if running the command returns the filenames. I'll suggest using the commit hash to compare. |
jackton1
changed the title
jackton1
added
bug
|
I was able to replicate the bug here: https://github.com/tj-actions/changed-files/runs/6548790981?check_suite_focus=true It should be a quick fix. |
|
Cool, please let me know when its fix and I will test. I really need this piece ;) |
|
@jackton1 Do you know when this might be pushed. Just trying to plan around its release. |
|
I would get the fix out late today 10 PM EST so it should be available by tomorrow morning |
|
@stevegroner The fix should be available in the latest release v20.2. Thanks for debugging this was really a huge help in narrowing down this bug. |
|
Confirmed. 20.2 works perfectly. Thank you so much for fixing it. |
jackton1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this feature missing in the latest version?
Is your feature request related to a problem? Please describe.
We see the new file appear in the list, but the old file name is nowhere to be found. Original filename was robot.txt
changed-files
Resolving repository path...
Retrieving changes between 0a570c11e5f8980f290d853b4f4891cc7dd9afcc (master) → 29380ed198095565b0764092090ec76e83e69b39 (master)
Getting diff...
Matching changed files: robots_files/robots-test.txt
Matching modified files: robots_files/robots-test.txt
Added files:
Copied files:
Deleted files:
Modified files:
Renamed files: robots_files/robots-test.txt
Type Changed files:
Unmerged files:
Unknown files:
All changed and modified files: robots_files/robots-test.txt
All changed files: robots_files/robots-test.txt
All modified files: robots_files/robots-test.txt
Describe the solution you'd like?
Would like to see some way of display the original filename/folder and the new filename/folder
Describe alternatives you've considered?
Haven't considered any alternatives as this tool is the source of truth
Anything else?
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: