[BUG] dir_names = true not returning directories with changed files

[discordianfish]

Is there an existing issue for this?

• I have searched the existing issues

Does this issue exist in the latest version?

• I'm using the latest release

Describe the bug?

Using:

      - name: Get changed files
        id: changed-files
        with:
          files: dir

It correctly detects the following changed files:

dir/foo/script.py
dir/bar/script.py

But setting dir_names = true returns no changed files. Also tried dir_names = "true" without it making a difference.

To Reproduce

Should be reproducable using these steps:

      - uses: actions/checkout@v2
        with:
          fetch-depth: 0
      - name: Get changed files
        id: changed-files
        with:
          files: dir
          dir_names: "true"
        uses: tj-actions/changed-files@v29.0.0

and then modifying files in dir//file

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-20.04

Expected behavior?

I expect steps.changed-files.outputs.all_changed_files to be set to:

• dir/foo
• dir/bar

Relevant log output

No response

Anything else?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

Thanks for reporting this issue, don't forget to star this project to help us reach a wider audience.

[jackton1]

@discordianfish Have you tried using?

      - name: Get changed files
        uses: tj-actions/changed-files@v29.0.0
        id: changed-files
        with:
          files: dir/**
          dir_names: "true"

[arthurk]

I have the same problem since upgrading to v29.

      - name: Get changed helm chart files
        id: changed-files-helm
        uses: tj-actions/changed-files@v29.0.0
        with:
          base_sha: ${{ steps.last_successful_commit.outputs.commit_hash }}
          dir_names: 'true'
          files: |
            helm-charts/**

It returns the correct files in v28, but none in v29

[jackton1]

@arthurk @discordianfish This bug has been fixed in the latest patch release.

[arthurk]

thanks for the quick fix, everything works again