Logical Issue in deepenShallowCloneToFindCommit

[hi-artem]

We have been using this action, and it periodically crashing while trying to deeper the shallow clone.

I am confused on the purpose of this loop:

changed-files/diff-sha.sh

Lines 78 to 89 in 58b52f3

	while ! git diff "$base_ref$diff$ref" &>/dev/null; do
	echo "::debug::Unable to find merge-base in shallow clone. Increasing depth to $((depth * 2))..."
	depth=$((depth * 2))
	if [[ $depth -gt $max_depth ]]; then
	echo "::error::Unable to find merge-base in shallow clone. Please increase 'max_fetch_depth' to at least $((depth + 20))."
	exit 1
	fi
	git fetch --no-tags -u --progress --deepen="$depth" origin "$target_branch":"$target_branch"
	done

You can just deepen it to max_fetch_depth. AFAIK there are no performance benefits to deepening it multiple times.

Also with the current approach there is no way to reach the special depth of 2147483647, which according to docs is infinite:

The special depth 2147483647 (or 0x7fffffff, the largest positive number a signed 32-bit integer can contain) means infinite depth.

[github-actions]

Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience.

[jackton1]

This function has been removed