Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for listing deleted submodules #999

Closed
3 tasks done
jckimble opened this issue Feb 25, 2023 · 1 comment · Fixed by #1001
Closed
3 tasks done

[Feature] Add support for listing deleted submodules #999

jckimble opened this issue Feb 25, 2023 · 1 comment · Fixed by #1001
Labels
enhancement New feature or request

Comments

@jckimble
Copy link

jckimble commented Feb 25, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Does this issue exist in the latest version?

  • I'm using the latest release

Describe the bug?

Delete variables empty.

I see that git diff --diff-filter=D in the main log shows the file but the return values are empty. Been playing with it for hours now trying to see if it's something I have wrong on configuration but with two different versions it still returns empty

To Reproduce

steps:
      - uses: actions/checkout@v3
        with:
          fetch-depth: 0
          submodules: recursive
      - id: config
        uses: ./.github/actions/load-config
      - name: Get deleted files
        id: deleted-files
        uses: tj-actions/changed-files@v35.5.6
        with:
          files_ignore: .github/**
          json: true
          json_raw_format: true
          match_directories: false

with both match_directories and on. Both versions are supplied in the log output.

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-20.04

Expected behavior?

Should return deleted file pcsxr in list

Relevant log output

https://github.com/jckimble/pkgbuilds/actions/runs/4269228333/jobs/7432286093

https://github.com/jckimble/pkgbuilds/actions/runs/4269246138/jobs/7432347193

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jckimble jckimble added the bug Something isn't working label Feb 25, 2023
@github-actions
Copy link
Contributor

Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience.

@jackton1 jackton1 linked a pull request Feb 26, 2023 that will close this issue
@jackton1 jackton1 changed the title [BUG] Not showing delete for removing submodule [Feature] Add support for listing deleted submodules Feb 26, 2023
@jackton1 jackton1 added enhancement New feature or request and removed bug Something isn't working labels Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants