[BUG] fail_on_error also fails on warnings

[simllll]

Is there an existing issue for this?

• I have searched the existing issues

Does this issue exist in the latest version?

• I'm using the latest release

Describe the bug?

I have an eslint warning (not an error);

also runnign it locally results into:

in the pipeline I think this is the relevant output for it:
{"ruleId":"@typescript-eslint/no-non-null-assertion","severity":1,"message":"Forbidden non-null assertion.","line":43,"column":19,"nodeType":"TSNonNullExpression","messageId":"noNonNull","endLine":43,"endColumn":54}
reviewdog: input data has violations
Warning: Error running eslint.

- name: Run eslint on changed files
        uses: tj-actions/eslint-changed-files@v10.2
        with:
          fail_on_error: true
          config_path: '.eslintrc.js'
          ignore_path: '.eslintignore'

fails, even though it's no an error, it's just a warning. It should fail on errors only, or do I miss something here?

To Reproduce

set fail_on_error: true and use a rule that only produces a warning and not an error.

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-20.04, ubuntu-18.04

Expected behavior?

It should only fail on errors, not on warnings

Relevant log output

No response

Anything else?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

Thanks for reporting this issue, don't forget to star this project to help us reach a wider audience.

[simllll]

Well it seems it's an upstream bug: reviewdog/action-eslint#62

[jackton1]

Based on https://github.com/reviewdog/reviewdog#exit-codes you can also take a look at changing the level option.

Since there is a related Issue. I'll close this one pending any further work on this issue.

[repo-ranger]

⚠️ This has been marked to be closed in 7 days.