Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to match when the changed file name is Chinese characters #370

Closed
4 tasks done
geihob opened this issue Jan 20, 2024 · 0 comments · Fixed by #371
Closed
4 tasks done

[BUG] Unable to match when the changed file name is Chinese characters #370

geihob opened this issue Jan 20, 2024 · 0 comments · Fixed by #371
Labels
bug Something isn't working

Comments

@geihob
Copy link

geihob commented Jan 20, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Does this issue exist in the latest version?

  • I'm using the latest release

Describe the bug?

When the changed file name is Chinese characters, *.outputs.changed_files is empty.

To Reproduce

    steps:
      - uses: actions/checkout@v4

      - name: Change text file
        run: |
          echo "Modified" > 啊啊啊.cpp

      - name: Verify Changed files
        uses: tj-actions/verify-changed-files@v17
        id: verify-changed-files
        with:
          files: |
            *.cpp

      - name: Run step only when any of the above files change.
        if: steps.verify-changed-files.outputs.files_changed == 'true'
        env:
          CHANGED_FILES: ${{ steps.verify-changed-files.outputs.changed_files }}
        run: |
          echo "Changed files: $CHANGED_FILES"

" Run step only when any of the above files change" won't run.

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-22.04

Expected behavior?

Support Chinese characters. : (

Relevant log output

##[debug]..Evaluating String:
##[debug]..=> 'changed_files'
##[debug]=> null
##[debug]Result: null
##[debug]Finishing: Verify Changed files

Has all relevant logs been included?

  • I've included all relevant logs

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@geihob geihob added the bug Something isn't working label Jan 20, 2024
@jackton1 jackton1 linked a pull request Jan 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant