Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fix without fetch/pull #125

Closed
1 task done
stevelacey opened this issue Aug 20, 2021 · 1 comment · Fixed by #127
Closed
1 task done

Support fix without fetch/pull #125

stevelacey opened this issue Aug 20, 2021 · 1 comment · Fixed by #127
Labels
enhancement New feature or request

Comments

@stevelacey
Copy link

Is your feature request related to a problem? Please describe.

The pull/fetch behavior is quite surprising, and doesn't work in some environments such as Docker, where the container does not have permission to fetch/pull from the remote.

For me it launched an ssh warning, because it's a Docker, with no access to my GitHub account, which lead me to reading the source to confirm the library was doing nothing untoward before proceeding, and then it didn't work anyway.

Describe the solution you'd like?

It'd be great if there was an option to skip that step, and assume the user has already brought their base branch up to date, commenting out https://github.com/tj-django/django-migration-fixer/blob/main/migration_fixer/management/commands/makemigrations.py#L115-L126 seems to do the trick.

Describe alternatives you've considered?

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@stevelacey stevelacey added the enhancement New feature or request label Aug 20, 2021
@jackton1 jackton1 linked a pull request Aug 21, 2021 that will close this issue
@jackton1
Copy link
Member

@stevelacey This should be resolved in the latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants