Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addHelpCommand missing from TypeScript definitions #1374

Closed
Zamiell opened this issue Oct 18, 2020 · 4 comments
Closed

addHelpCommand missing from TypeScript definitions #1374

Zamiell opened this issue Oct 18, 2020 · 4 comments
Labels
bug Commander is not working as intended

Comments

@Zamiell
Copy link

Zamiell commented Oct 18, 2020

Hello,

It looks the addHelpCommand method definition is missing in the TypeScript definitions file here:
https://github.com/tj/commander.js/blob/master/typings/index.d.ts

Is this a bug?
@shadowspawn shadowspawn added the bug Commander is not working as intended label Oct 18, 2020
@shadowspawn
Copy link
Collaborator

Short version: yes.

Got missed in a big PR, #1149. Thanks. 👍

@shadowspawn shadowspawn mentioned this issue Oct 19, 2020
Merged
@shadowspawn shadowspawn added pending release Merged into a branch for a future release, but not released yet and removed pending release Merged into a branch for a future release, but not released yet labels Oct 19, 2020
@shadowspawn
Copy link
Collaborator

Released in Commander v6.2.0

@shadowspawn
Copy link
Collaborator

Released in Commander v6.2.0

@Zamiell
Copy link
Author

Zamiell commented Oct 25, 2020

thanks john, appreciate your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Commander is not working as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zamiell @shadowspawn