Proposals for on/off switch

[ntkme]

The justification for this has been discussed #108. I have working code but I'd like to open a discussion before opening a PR.

Proposal 1

program
  .version('0.0.1')
  .option('    --[no-]color', 'optionally turn on or off the color');

Proof of concept implementation:

https://github.com/ntkme/commander.js/compare/master...ntkme:optional-switch

Pros

• Small overhead
• Default value works as expected

Cons

• No short flag

Proposal 2

program
  .version('0.0.1')
  .option('-c, --color', 'enable color')
  .option('-C, --no-color', 'disable color')

Proof of concept implementation:

https://github.com/ntkme/commander.js/compare/master...ntkme:boolean-switch

Pros

• Short flag works fine

Cons

• The proof of concept implementation has to take a look back at all previous options, which means:
  • Weak performance
  • Default value has to be set on the second option
  • Can be overcome by setting default values only when calling .parse() (breaking change, not a good idea)

[abetomo]

@ntkme Thank you.
I think that Proposal 1 is good.

@vanesyan What do you think?

[syberkitten]

Hey Guys
It's so missing.... there are so many times I want to use a switch,
and right the way to achieve this is to use normal arguments adding them a value just to
make a switch.