Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typedefs: Command and Option types added to commander namespace #713

Merged
merged 1 commit into from Dec 8, 2017

Conversation

jsamr
Copy link
Contributor

@jsamr jsamr commented Nov 13, 2017

Before commit, the constructor is resolved but not the type1

image

After commit, the type Command is resolved

image

The goal of this typedef enhancement is to allow the library consumer to use Command and Option types which he cannot yet use, in peculiar when receiving action callback arguments.
The way I do this is by creating a local namespace which contains class definitions and to cast those definition to a type (i.e. interface) in the commander namespace. By doing so, the types are accessible to library consumer.


1 with typescript 2.5.3 and CommonJS modules

@abetomo abetomo merged commit fefda77 into tj:master Dec 8, 2017
@ball6847
Copy link

ball6847 commented Jan 7, 2018

How long it's gonna take before releasing the next version ?

I'm facing this problem and looking forward to use this.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants