pull-request command cannot find email settings

[jldugger]

The man page git-commit-tree outlines how user.email is set:

In case (some of) these environment variables are not set, the information is taken from the configuration items user.name and user.email, or, if not present, the environment variable EMAIL,

I'm using EMAIL=jldugger@osuosl.org, and git config recognizes this:

repo $ git config -l | grep user.email
user.email=jldugger@osuosl.org

However, pull-request does not:

repo $ git pull-request
git config user.email required

[spacewander]

Would you like to submit a pull request to fix this behavior?

[jldugger]

Well, shoot, now I can't replicate the git config -lbit. I probably set up an environment variable to fix this and forgot about it.

Would there be an objection to using EMAIL as a fallback if git config user.email is empty?

[nicolaiskogheim]

Would there be an objection to using EMAIL as a fallback if git config user.email is empty?

@jldugger It doesn't strike me as bad to do that, but I don't think that ever should be necessary. Commit'ing requires email to be set, so that's something a user of git-pr should be expected to do as well. I am voting no to this, mostly because git doesn't fall back to EMAIL.

[jldugger]

@nicolaiskogheim actually, git does fall back to EMAIL. It's explicitly mentioned in the git-commit-tree manpage I quoted above. git config simply isn't listing it, presumably because EMAIL is not part of git configuration files.

My purpose here is unify configurations between personal and work computers, and use env variables to manage role dependent settings like EMAIL. This strategy is already working for git itself, but surprisingly not for git-pull-request. It's a pretty simple fix, but I'm not going to bother submitting a PR if maintainers are actively against it.

[nicolaiskogheim]

@nicolaiskogheim actually, git does fall back to EMAIL

Then we shall do the same.

I apologise. I skimmed this thread and didn't even see that you quoted git. Moreover, I was convinced that git didn't look in the env for email.

I don't know why you were so quick to assume that anyone in here are opposed to doing things like git does. My argument for turning your proposal down was solely based on what I believed git did. As it turns out, both of the statements I claimed true was wrong. And as any logically coherent human being, I must now accept you proposal, and encourage it. Both of which I of course do.

[jldugger]

Change merged, so closing issue.