New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old io project support #516
Conversation
This looks good @JohnRGee, I just have to bump the version to a breaking change because the functionality will not be the same as 2.1.x anymore. I'm working through the PRs to try to find which is the easiest to merge. Also, I want to build a changelog out of the commits and generate it with a release. |
I have resolved the merge conflict with updated master using the GitHub interface. (If that isn't convenient, I can do a rebase and force push.) |
I use this to get the nightly build for node.green:
This change broke that. Is there something new or better way of doing it? I've been forcing version 2.1.7 since this change- would love to run a newer version. See: https://github.com/williamkapke/node-compat-table/blob/gh-pages/test.sh#L6 |
@williamkapke The nightly builds have been explicitly supported since
A longer example to match against your previous scripting:
Support for |
🤦 Aaaahh the problem is that it was made TOO easy and I was looking for something hard! haha Thanks for the help. Glad node.green has been useful for you!! It has always used |
Pull Request Template:
Describe what you did
Removed old iojs from code and help.
How you did it
Removed old iojs support from code, and old iojs examples from command-line help and README.
How to verify it doesn't effect the functionality of n
$ n 8.0.0
######################################################################## 100.0%
installed : v8.0.0
Bagheera:n john$ n lts
######################################################################## 100.0%
installed : v8.11.3
$ PROJECT_NAME="iojs" PROJECT_URL="https://iojs.org/dist/" n project latest
######################################################################## 100.0%
installed : v3.3.1
$ n bin 8.0.0
/usr/local/n/versions/node/8.0.0/bin/node
$ n use 8.0.0 --version
v8.0.0
If this solves an issue, please put issue in PR notes.
Resolves issue #331
If this solves an issue, please include the output of issue that had problems and then the fixed output from the same command.
Remove old iojs support from help and code.
Squash any unnecessary commits to keep history clean as possible
Place description for the changelog in PR so we can tally all changes for any future release