Updated clearfix #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sounds good thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A clearfix method requiring fewer CSS properties was first discussed on this blog post
html5-boilerplate was subsequently updated paulirish/html5-boilerplate@ac92ae7
I did my own extensive testing in IE 6/7/8/9/10pre, Chrome 11/12, Safari 5, Firefox 3.0/3.6/4, Opera 10.63/11 and mobile Safari. Found only one regression between the two methods. In Firefox versions prior to 3.5 if the clearfix is applied to the first child of the body and the first child does not have non-zero padding then extra space will appear between the first child and the body as reported on the blog post.
I think that the one edge case with legacy Firefox versions is not worth the extra properties.
Imported clearfix in the index so it can be easily used when including the whole of nib via stylus include.
Used the support-for-ie variable to toggle zoom:1 as turned off it saves a few lines of compiled CSS per use of the mixin.
Also updated the comment noting the Firefox regression and a IE 6/7 issue that is the same between both clearfix methods.
I think this is pretty much done so now I can move onto working on other interesting things for nib =)
Cheers,
Isaac