Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error thrown with non-square images #2

Closed
tjof2 opened this issue Jan 13, 2016 · 1 comment
Closed

Error thrown with non-square images #2

tjof2 opened this issue Jan 13, 2016 · 1 comment
Assignees
Labels

Comments

@tjof2
Copy link
Owner

tjof2 commented Jan 13, 2016

Code currently fails to deal with non-square images.

@tjof2 tjof2 added the bug label Jan 13, 2016
@tjof2 tjof2 self-assigned this Jan 13, 2016
@tjof2 tjof2 added this to the 0.2 milestone Jan 13, 2016
@tjof2
Copy link
Owner Author

tjof2 commented Mar 6, 2016

This will be fixed in #8, although it is not clear how best to overcome problems with the quadtree segmentation procedure for noise estimation (which requires a square image at the moment). The PGURE-SVT step doesn't need square images, and will handle them successfully in #8.

The proposed solution for now will be a simple error message, (perhaps best handled in the Python wrapper?), inviting the user to crop/select the area they want to process if they want to do noise estimation. After all, noise estimation may not always be required.

@tjof2 tjof2 mentioned this issue Mar 6, 2016
6 tasks
@tjof2 tjof2 removed this from the 0.2 milestone Mar 17, 2016
@tjof2 tjof2 closed this as completed Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant