-
Notifications
You must be signed in to change notification settings - Fork 149
/
AvoidingRedundantJoinE2eTest.java
125 lines (107 loc) · 4.21 KB
/
AvoidingRedundantJoinE2eTest.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
/**
* Copyright 2014-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package net.kaczmarzyk;
import static java.util.Arrays.asList;
import static net.kaczmarzyk.utils.LoggedQueryAssertions.assertThat;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
import org.junit.Before;
import org.junit.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.data.domain.Page;
import org.springframework.data.domain.Pageable;
import org.springframework.data.jpa.domain.Specification;
import org.springframework.data.web.PageableDefault;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.RestController;
import net.kaczmarzyk.spring.data.jpa.Movie;
import net.kaczmarzyk.spring.data.jpa.MovieRepository;
import net.kaczmarzyk.spring.data.jpa.Person;
import net.kaczmarzyk.spring.data.jpa.domain.Like;
import net.kaczmarzyk.spring.data.jpa.web.annotation.And;
import net.kaczmarzyk.spring.data.jpa.web.annotation.Join;
import net.kaczmarzyk.spring.data.jpa.web.annotation.Joins;
import net.kaczmarzyk.spring.data.jpa.web.annotation.Spec;
/**
* @author Tomasz Kaczmarzyk
*/
public class AvoidingRedundantJoinE2eTest extends E2eTestBase {
@Joins({
@Join(path = "stars", alias = "s"),
@Join(path = "directors", alias = "d")
})
@And({
@Spec(path = "name", params = "name", spec = Like.class),
@Spec(path = "s.name", params = "star", spec = Like.class),
@Spec(path = "d.name", params = "director", spec = Like.class)
})
public static interface MovieSpec extends Specification<Movie> {
}
@RestController
public static class MovieController {
@Autowired
MovieRepository repository;
@GetMapping("/movies")
public Page<Movie> findMoviesByStarsAndDirectors(MovieSpec spec, @PageableDefault Pageable pageable) {
return repository.findAll(spec, pageable);
}
}
@Before
public void persistTestData() {
em.persist(new Movie("Bart's Not Dead",
asList(new Person("Bart Simpson"), new Person("Homer Simpson")),
asList(new Person("Bob Anderson"))));
em.persist(new Movie("Heartbreak Hotel",
asList(new Person("Marge Simpson"), new Person("Lisa Simpson")),
asList(new Person("Steven Dean Moore"))));
em.persist(new Movie("My Way or the Highway to Heaven",
asList(new Person("Marge Simpson"), new Person("Homer Simpson")),
asList(new Person("Rob Oliver"))));
}
@Test
public void performsEachJoinOnlyOnce() throws Exception {
mockMvc.perform(get("/movies?star=Homer&director=Anderson"))
.andExpect(status().isOk())
.andExpect(jsonPath("$.totalElements").value(1));
assertThat()
.numberOfPerformedHqlQueriesIs(1)
.andQueryWithIndex(0)
.hasNumberOfJoinsForPath(".stars", 1)
.hasNumberOfJoinsForPath(".directors", 1);
}
@Test
public void performsJoinOnlyIfUsedInFiltering() throws Exception {
mockMvc.perform(get("/movies?star=Homer"))
.andExpect(status().isOk())
.andExpect(jsonPath("$.totalElements").value(2));
assertThat()
.numberOfPerformedHqlQueriesIs(1)
.andQueryWithIndex(0)
.hasNumberOfJoinsForPath(".stars", 1)
.hasNumberOfJoinsForPath(".directors", 0);
}
@Test
public void doesNotJoinAtAllIfFilteringNotAppliedOnJoinPaths() throws Exception {
mockMvc.perform(get("/movies"))
.andExpect(status().isOk())
.andExpect(jsonPath("$.totalElements").value(3));
assertThat()
.numberOfPerformedHqlQueriesIs(1)
.andQueryWithIndex(0)
.hasNumberOfJoins(0);
}
}