Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is hash_test[_aes] for? #28

Closed
CryZe opened this issue Dec 26, 2019 · 2 comments
Closed

What is hash_test[_aes] for? #28

CryZe opened this issue Dec 26, 2019 · 2 comments

Comments

@CryZe
Copy link

CryZe commented Dec 26, 2019

Those seem like dead code, but they show up as public exports in my WebAssembly. If they are necessary for some automated testing, maybe they could be moved to some testing feature flag?

 (export "hash_test" (func $hash_test))
@tkaitchuck
Copy link
Owner

Those are there as inspection points so that I can easily locate and read the generated assembly.
It's weird they are they showing up as public? They aren't pub. They don't show in docs...

I could put them behind a feature flag, but it's probably easier to comment them out.

@tkaitchuck
Copy link
Owner

Commented out in 0.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants