Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get author and committer from a config variable or default out. #21

Closed
ishworgurung opened this issue Jan 4, 2022 · 3 comments · Fixed by #67
Closed

Get author and committer from a config variable or default out. #21

ishworgurung opened this issue Jan 4, 2022 · 3 comments · Fixed by #67
Labels
good first issue Good for newcomers

Comments

@ishworgurung
Copy link

Neat idea. I think, for dura auto-commit vs. a human commit, it'd be nicer to distinguish the author and committer.

&head.author(),

@chand1012 chand1012 mentioned this issue Jan 4, 2022
@tkellogg
Copy link
Owner

tkellogg commented Jan 4, 2022

oh yes! It could be something like dura@github.io. I'm not sure about the benefits of having the email be a real email address though.

@eauxpie
Copy link

eauxpie commented Jan 7, 2022

also being able to use the git configured author instead of whoever the author of head was. I don't need to distinguish dura commits from my other commits, but I do want them to show up consistently as mine, not whoever last pushed to that branch

@tkellogg
Copy link
Owner

tkellogg commented Jan 8, 2022

A good approach would be

  1. Default to the settings of git config
  2. Override in the config file

Details around the config file are being hashed out in #25, but we can easily take approach \1 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants