Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minidlna: Wrong sort order when browsing large collections #31

Open
tkem opened this issue Oct 16, 2015 · 6 comments
Open

minidlna: Wrong sort order when browsing large collections #31

tkem opened this issue Oct 16, 2015 · 6 comments

Comments

@tkem
Copy link
Owner

tkem commented Oct 16, 2015

Might be a server-side (minidlna) issue -- when browsing "All Music", items are sorted partially, probably matching batch size.

@tkem tkem added the bug label Oct 16, 2015
@tkem
Copy link
Owner Author

tkem commented Oct 17, 2015

For this to work, dLeynaClient.browse should get an extra order parameter, and use ListChildrenEx, of course. Sort order should be checked with the device's SortCaps. Somehow assumed this was already implemented...

@tkem tkem added this to the v1.0.3 milestone Oct 18, 2015
@tkem
Copy link
Owner Author

tkem commented Oct 21, 2015

Probably needs new config settings: upnp_browse_order, upnp_search_order: list of types, actual filter is intersection with device sort caps. Requires a new minor release version (v1.1).

@tkem
Copy link
Owner Author

tkem commented Oct 23, 2015

Calling ListChildrenEx with sort order set to +DisplayName shows the same behavior. Sort order seems to be honored for the first n (~1000) items only. Note this seems to be independent of batch size -- setting upnp_browse_limit to 10 shows the same behavior (first ~1000 items sorted ok, then starting from "a"). WTF?

@tkem
Copy link
Owner Author

tkem commented Dec 27, 2015

Another issue with using SortCaps would be how to distinguish between albums, which should probably be sorted by track number, and other directories, which are to be sorted by name.

@tkem
Copy link
Owner Author

tkem commented Jan 10, 2016

Sort order improvements will be tracked in #37.

@tkem tkem modified the milestone: v1.1.0 Jan 18, 2016
@tkem
Copy link
Owner Author

tkem commented Jan 20, 2016

This might be an explanation, however __sparc__ should not be defined on the test server:
http://sourceforge.net/p/minidlna/git/ci/v1_1_4/tree/upnpsoap.c#l75

@tkem tkem changed the title Wrong sort order when browsing collections larger than upnp_browse_limit minidlna: Wrong sort order when browsing large collections Jan 20, 2016
@tkem tkem added server specific and removed bug labels Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant