Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using internalversion for supporting k8s 1.19+ #1083

Closed
leoryu opened this issue Feb 4, 2021 · 0 comments · Fixed by #1169
Closed

Stop using internalversion for supporting k8s 1.19+ #1083

leoryu opened this issue Feb 4, 2021 · 0 comments · Fixed by #1169
Labels
kind/feature Feature Request

Comments

@leoryu
Copy link
Contributor

leoryu commented Feb 4, 2021

kubernetes/kubernetes#90018

Fallback to reflect-based conversions was removed in 1.19 because they are lossy and mask missing field conversions. This change may not affect CRD. We should stop using internalversion in proxy which forward request to k8s basic object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(platform): stop using internalversion leoryu/tke
1 participant
@leoryu