Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor should allow empty username and password #1344

Closed
xiaosuiba opened this issue Jun 7, 2021 · 0 comments · Fixed by #1345
Closed

Monitor should allow empty username and password #1344

xiaosuiba opened this issue Jun 7, 2021 · 0 comments · Fixed by #1345
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@xiaosuiba
Copy link
Contributor

What happened:
monitor does not allow empty username and password for elasticsearch storage type.
es

What you expected to happen:
could use elasticsearch storage type monitor without username and password, like any other settings related to elasticsearch.

How to reproduce it (as minimally and precisely as possible):

  1. install a new tke with elasticsearch as monitor storage backend.
  2. do not provide username and password

Anything else we need to know?:

type ESMonitor struct {
	URL      string `json:"url" validate:"required"`
	Username string `json:"username" validate:"required"`
	Password []byte `json:"password" validate:"required"`
}

Environment:

  • TKE version: v1.6.0
  • Global or business cluster: global
  • Kubernetes version (use kubectl version):
  • Install addons:
  • Others:
@xiaosuiba xiaosuiba added the kind/bug Categorizes issue or PR as related to a bug. label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant