Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installer): add request and limit resources for cilium workload #1602

Merged
merged 1 commit into from Sep 28, 2021

Conversation

yunjianzhong
Copy link
Contributor

/kind bug

currently the request and limit resources weren't set in the manifests of the cilium workloads. this pull request is target to solve the issue.

Fixes #1312

@leoryu
Copy link
Contributor

leoryu commented Sep 26, 2021

@yunjianzhong your commit message doesn't pass the lint check. In your case, commit message should be fix(installer): add request and limit resources for cilium workload.

@leoryu
Copy link
Contributor

leoryu commented Sep 26, 2021

@yunjianzhong
Copy link
Contributor Author

@yunjianzhong your commit message doesn't pass the lint check. In your case, commit message should be fix(installer): add request and limit resources for cilium workload.

I just changed the commit message, please check. thanks!

@leoryu
Copy link
Contributor

leoryu commented Sep 26, 2021

@yunjianzhong your commit message doesn't pass the lint check. In your case, commit message should be fix(installer): add request and limit resources for cilium workload.

I just changed the commit message, please check. thanks!

I think you missed a space after :.

@yunjianzhong
Copy link
Contributor Author

@yunjianzhong your commit message doesn't pass the lint check. In your case, commit message should be fix(installer): add request and limit resources for cilium workload.

I just changed the commit message, please check. thanks!

I think you missed a space after :.

got it, changed again.

@leoryu leoryu merged commit 6e8f177 into tkestack:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all cilium workloads should config resource req/lim
2 participants