Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(console): create computer can't add label (for master) #2119

Merged
merged 2 commits into from Oct 17, 2022
Merged

fix(console): create computer can't add label (for master) #2119

merged 2 commits into from Oct 17, 2022

Conversation

jo-hnny
Copy link
Collaborator

@jo-hnny jo-hnny commented Oct 17, 2022

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug

What this PR does / why we need it:

  1. role list can't search;
  2. create computer can't add label

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@jo-hnny jo-hnny requested a review from Yacent as a code owner October 17, 2022 09:08
wangpand0508
wangpand0508 approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@wangpand0508 wangpand0508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leoryu leoryu merged commit c254119 into tkestack:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangpand0508 wangpand0508 wangpand0508 approved these changes

@Yacent Yacent Awaiting requested review from Yacent Yacent is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jo-hnny @wangpand0508 @leoryu