feat(platform): split machine resource validate #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoryu
force-pushed
the
splite-validate-items
branch
from
868590e
to
5d29955
Compare
wl-chen
reviewed
Nov 22, 2022
| if isNeedValidateForDynamicItem(AnywhereValidateItemMachineResourceMemory, cls) { | ||
| memoryErrs = ValidateMachineResource(fldPath, masters) | ||
| memoryResult.Checked = true | ||
| log.Infof("cls %s's %s is validated", cls.Spec.DisplayName, AnywhereValidateItemMachineResourceCPU) |
leoryu
force-pushed
the
splite-validate-items
branch
from
5d29955
to
7b0652e
Compare
wl-chen
reviewed
Nov 22, 2022
| memoryResult.Description = "Verify Memory" | ||
| memoryResult.ErrorList = memoryErrs | ||
|
|
||
| routeResult.Name = AnywhereValidateItemDefaultRoute |
leoryu
force-pushed
the
splite-validate-items
branch
from
7b0652e
to
e596fa7
Compare
wl-chen
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: