Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): copy provider config in test #2288

Merged
merged 1 commit into from May 17, 2023
Merged

fix(ci): copy provider config in test #2288

merged 1 commit into from May 17, 2023

Conversation

leoryu
Copy link
Contributor

@leoryu leoryu commented May 17, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@leoryu leoryu requested a review from choujimmy as a code owner May 17, 2023 06:16
var _ = Describe("node", func() {
baremetalcluster.RegisterProvider()
copyProviderConfig()
bp, _ := baremetalcluster.NewProvider()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bq 这个参数搞个全称吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@leoryu leoryu merged commit ef04652 into master May 17, 2023
3 checks passed
@leoryu leoryu deleted the fix-master-ci branch May 17, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants