fix(platform): compatible webhook's certificate and private key #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangao1236
force-pushed
the
fix-old-clusters-webhook-cert-and-key
branch
from
bb0b4fc
to
879ccb0
Compare
huxiaoliang
reviewed
Nov 9, 2020
| @@ -58,11 +59,35 @@ type Option struct { | |||
| IsGlobalCluster bool | |||
| } | |||
|
|
|||
| // WebhookCertAndKeyExist checks whether the certificate and private key exist, | |||
| // for compatibility with old version clusters' webhook certificates and private keys. | |||
There was a problem hiding this comment.
please highlight this is involved for tke1.5 and will get removed from tke1.6 or future
wangao1236
force-pushed
the
fix-old-clusters-webhook-cert-and-key
branch
from
879ccb0
to
7305c22
Compare
wangao1236
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #886
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: