feat(installer): support upgrade through installer #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoryu
force-pushed
the
installer_upgrade
branch
from
5bd6655
to
60139c2
Compare
huxiaoliang
reviewed
Nov 30, 2020
| @@ -142,7 +142,7 @@ function clean_old_data() { | |||
| function start_installer() { | |||
| echo "Step.5 start tke-installer [doing]" | |||
|
|
|||
| docker run $OPTIONS "tkestack/tke-installer-${ARCH}:$VERSION" | |||
| docker run $OPTIONS "tkestack/tke-installer-${ARCH}:$VERSION" /app/bin/tke-installer $@ | |||
There was a problem hiding this comment.
I don't think need duplicate /app/bin/tke-installer again here
huxiaoliang
reviewed
Nov 30, 2020
| if len(depl.Spec.Template.Spec.Containers) == 0 { | ||
| return fmt.Errorf("%s has no containers", com) | ||
| } | ||
| depl.Spec.Template.Spec.Containers[0].Image = images.Get().TKEPlatformController.FullName() |
There was a problem hiding this comment.
depl.Spec.Template.Spec.InitContainers[0].Image
leoryu
force-pushed
the
installer_upgrade
branch
from
e909833
to
607a0ea
Compare
|
@leoryu please handle the tke.json already exist case and retest |
willemswang
pushed a commit
to willemswang/tke
that referenced
this pull request
Dec 3, 2020
* feat(installer): support upgrade through installer * fix(installer): fix installer registry nil pointer * feat(platform): remove save third party registry * feat(platform): load tke data before upgrade * feat(platform): move load func to installer
pavlelee
pushed a commit
to GaoXiaodong/tke
that referenced
this pull request
Dec 16, 2020
* feat(installer): support upgrade through installer * fix(installer): fix installer registry nil pointer * feat(platform): remove save third party registry * feat(platform): load tke data before upgrade * feat(platform): move load func to installer
pavlelee
pushed a commit
to GaoXiaodong/tke
that referenced
this pull request
Dec 16, 2020
)" This reverts commit 2e1e884.
pavlelee
pushed a commit
to GaoXiaodong/tke
that referenced
this pull request
Dec 16, 2020
)" This reverts commit 2e1e884.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: