Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation migration to ReadTheDocs #25

Closed
RedFantom opened this issue Oct 18, 2018 · 14 comments
Closed

Documentation migration to ReadTheDocs #25

RedFantom opened this issue Oct 18, 2018 · 14 comments
Labels
repo Repository meta files and documentation

Comments

@RedFantom
Copy link
Member

RedFantom commented Oct 18, 2018

Discussion on this topic started on 05b33e1, but I thought it would be more appropriate to move it to an issue.

This issue is progressing in the sphinx_doc branch, created by @j4321.

I will add this repository to my ReadTheDocs account so the documentation is built automatically.

@RedFantom RedFantom added the repo Repository meta files and documentation label Oct 18, 2018
@RedFantom
Copy link
Member Author

The documentation on sphinx_doc builds just fine on ReadTheDocs, so it is definitely my environment where it is going wrong. It currently looks like this.

@j4321
Copy link
Member

j4321 commented Oct 18, 2018

Maybe we can add the examples in a dedicated section?

@RedFantom
Copy link
Member Author

That is a great idea. I'm not sure whether such files can be created by sphinx by itself? Otherwise I could write a small script that formats the examples the proper way.

@j4321
Copy link
Member

j4321 commented Oct 18, 2018

As far as I know sphinx cannot generates these files automatically so writing a script seems the best option.

@RedFantom
Copy link
Member Author

What do you think about the current implementation?

@j4321
Copy link
Member

j4321 commented Oct 18, 2018

I think the current implementation is good, sphinx was just complaining about one misplaced newline in examples.rst so I corrected the script.

I also reduced the toctree depth to 1 on the home page because Examples was the only section with displayed subsections.

@j4321
Copy link
Member

j4321 commented Oct 18, 2018

@RedFantom This is not directly related to the documentation, but reading the Installation section made me think about it: If you agree I can make a .deb package for ttkwidgets and make it available in a ppa on my launchpad account.

@RedFantom
Copy link
Member Author

Oh, sure! I really wouldn't know how to do that or how to maintain that, but it does sound like it could be useful to some users.

What format would you like for the docstrings? I can try to help out over the next few days, but I'm not sure how much time I will have.

@j4321
Copy link
Member

j4321 commented Oct 18, 2018

Ok great. I think we should use the standard sphinx formatting (https://sphinx-rtd-tutorial.readthedocs.io/en/latest/docstrings.html). Some of the modules already use it, like in linklabel.py.

@j4321
Copy link
Member

j4321 commented Oct 23, 2018

I have changed a bit the Examples section (63be42b) so that the TOC is split into subpackages like the documentation. I find it clearer that way (especially once there will be one example per widget).

@RedFantom I plan to write the missing examples, do you prefer me to commit them in this branch or in a separate one?

@RedFantom
Copy link
Member Author

I suppose a separate branch would be appropriate.

Thanks for the tips on the TimeLine docstrings! I will get to them as soon as I can.

@RedFantom
Copy link
Member Author

@j4321 It's been a while, and I've been busy, but I think the documentation is complete now, right? At least, every widget has a documentation entry and it looks good. Do you agree that it is ready for a PR?

@j4321
Copy link
Member

j4321 commented Dec 6, 2018

@RedFantom I agree, I was thinking about opening a PR but got caught up with other things.

@RedFantom
Copy link
Member Author

The branch sphinx_doc has been merged, and the documentation was built successfully. Thank you so, so much for all your hard work on this, @j4321 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo Repository meta files and documentation
Projects
None yet
Development

No branches or pull requests

2 participants