Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label files with packets granularity #105

Open
g0wzancha opened this issue Feb 10, 2020 · 1 comment
Open

Label files with packets granularity #105

g0wzancha opened this issue Feb 10, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@g0wzancha
Copy link

g0wzancha commented Feb 10, 2020

Label files can be extended to include a reference to all the packets that an attack injected.

The current implementation creates one XML labels file that indicates when an attack starts and ends (along with the IPs that took part in the attack). In this setting, it is possible that packets that were not part of an attack are mistaken as being generated by an attack script.

For more precise labeling, we could store in the XML file some identifier (or a pointer) that refers to individual and unique packets. For example, the hashes or packet numbers in the resulting PCAP of the synthetic packets can be added to the XML labels file.

@UndeadKernel UndeadKernel changed the title [Label file] enrich with packet identifiers Label files with packets granularity Feb 10, 2020
@pepper-jk pepper-jk added the enhancement New feature or request label Feb 12, 2020
@pepper-jk
Copy link
Collaborator

pepper-jk commented Feb 12, 2020

We were planning to make the hidden.mark parameter from the P2PBotnet globally available to all attacks.

Would you find that sufficient, or would you still suggest an additional label file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants